fix: update theme stylesheet access pattern #2573
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2336
This PR replaces bracket notation for theme access with optional chaining to align with the
Theme
interface style.Motivation
The current implementation has a discrepancy between the
Theme
interface defined in TypeScript versus the JavaScript styling logic. This can lead to a poor developer experience, as the interface should serve as a guide for interacting with the library. The following examples illustrate the need for this change.Example 1: Conforms to the
Theme
Interface but Does Not Apply the Custom StylingIn this example, the code adheres to the
Theme
interface, but the JavaScript does not apply the theme's styling correctly.Example 2: Applies Custom Styles but Does Not Conform to the Theme Interface
In this case, custom styles are applied, but the implementation does not conform to the Theme interface, leading to TypeScript complaints.