Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PD-I188: Added the configuration to display bestselling products on no results page. #156

Merged
merged 1 commit into from
Mar 26, 2025
Merged

PD-I188: Added the configuration to display bestselling products on no results page. #156

merged 1 commit into from
Mar 26, 2025

Conversation

smit-kandiya
Copy link
Collaborator

…o result page

@smit-kandiya smit-kandiya requested a review from alok0590 March 18, 2025 05:44
@alok0590
Copy link
Member

We will need to write patch to set default values of

  • title
  • Number of pinned products to display
  • Sub Title

Let me know if any confusion.

alok0590
alok0590 requested changes Mar 19, 2025
View reviewed changes
@smit-kandiya smit-kandiya force-pushed the PD-I188 branch 3 times, most recently from 9882a5d to 0d28550 Compare March 19, 2025 10:40
@smit-kandiya smit-kandiya requested a review from alok0590 March 19, 2025 10:40
alok0590
alok0590 requested changes Mar 21, 2025
View reviewed changes
Services/Setup/Version324.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be Version325.php

Setup/Patch/Data/PatchV324.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be PatchV325.php

etc/adminhtml/system.xml Outdated
<source_model>Wizzy\Search\Model\Admin\Source\CategoriesListWithHandle</source_model>
<comment>
<![CDATA[
Select Category which Wizzy should use to display no results products.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select Category which Wizzy should use to display products on no results found page.

view/frontend/templates/search/empty-results.phtml Outdated
<p><?= $block->escapeHtmlAttr(__('Please check the spelling or try searching for something else.')); ?></p>
{{#query}}
<div class="wizzy-empty-results-summary">
<p>You searched for <span class="wizzy-empty-searched-query">{{ query }}</span></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display like,

<?= $block->escapeHtmlAttr(__('You searched for')); ?>

view/frontend/templates/search/empty-results.phtml Outdated

{{#query}}
<p>Please check the spelling or try searching for something else.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use

$block->escapeHtmlAttr(__(

view/frontend/templates/search/empty-results.phtml Outdated
{{#lastRequestId}}
<p class="wizzy-req-ref-id"><?= $block->escapeHtmlAttr(__('Ref ID:')); ?> {{ lastRequestId }}</p>
<p class="wizzy-req-ref-id">Ref ID: {{ lastRequestId }}</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<?= $block->escapeHtmlAttr(__('Ref ID:')); ?>

view/frontend/templates/search/empty-results.phtml Outdated
<ul class="wizzy-search-results-list">
{{#suggestions}}
{{& html}}
{{/suggestions}}
</ul><!-- ending of wizzy-search-results-list -->
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are removing </div>

@smit-kandiya smit-kandiya requested a review from alok0590 March 21, 2025 10:09
@alok0590 alok0590 merged commit 1f71675 into dev Mar 26, 2025
2 checks passed
@alok0590 alok0590 deleted the PD-I188 branch March 26, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alok0590 alok0590 alok0590 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smit-kandiya @alok0590