Skip to content

Add default dispose callback #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sparksp wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add default dispose callback #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c95db50
Remove unused `debounce`
sparksp Jul 17, 2020
2ce55e9
Add default myDisposeCallback
sparksp Jul 17, 2020
f45765d
Remove empty travis config
sparksp Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .travis.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion lib/src/watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const { getPropOr } = require('crocks/helpers/')
const { watchingDirs, eventNotification } = require('./messages')
const { build, buildIsReload, updateToWatching } = require('./build')
const { sendMessage, sendCompilingMessage } = require('./start')
const { inArray, debounce, update, noop } = require('./utils')
const { inArray, update, noop } = require('./utils')

/*
|-------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion lib/src/websocket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// The following 20 lines are from https://github.com/klazuka/elm-hot/blob/master/test/client.js#L40
var myDisposeCallback = null
var myDisposeCallback = function () {};

// simulate the HMR api exposed by webpack
var module = {
Expand Down