Remove bus type restrictions and add reboot handling for LED settings #4964

Copilot · 2025-09-28T06:26:02Z

Fixed Bus Type Change Restrictions with Reboot Handling

Successfully implemented the solution to allow bus type changes while prompting for reboot instead of restricting them, with all reviewer feedback addressed.

Changes Completed:

Technical Details:

Frontend Changes (settings_leds.htm):

Removed if (i < LTs.length-1) s.disabled = true; restriction
Added state tracking variables and functions
Enhanced form submission to detect changes and prompt for reboot
Code cleanup: Streamlined change detection to only track bus types (removed unused originalBusCount)
Smart filtering: Only physical hardware buses trigger reboot, virtual/network buses exempted
Added hidden RBT=1 field when reboot is required

Backend Changes (set.cpp):

Added reboot handling: if (request->hasArg(F("RBT"))) doReboot = true; in SUBPAGE_LEDS

User Experience:

All bus type selects are now enabled and editable
Virtual and network buses don't trigger reboot requirements (hardware-independent)
When physical bus types change, user gets a concise confirmation dialog
User can choose to proceed (with reboot) or cancel the changes
System automatically reboots after saving when required
Clean, optimized code without unused variables

This resolves the confusing restriction behavior and provides a user-friendly approach to handling hardware changes that require reboot, with improved logic and clean code structure based on all reviewer feedback.

Original prompt

This section details on the original issue you should resolve

<issue_title>Reboot instead of restricting LED-type change with multiple buses</issue_title>
<issue_description>When adding more than one bus in LED settings, editing the type is only possible for the last bus.
This is to ensure proper hardware initialisation.
However, this is confusing to users and should be handled differently. Instead of restricting it in the settings, a variable should be added to the LED settings page that keeps track of the problematic changes i.e. the bus type and if necessary, display a warning and issue a reboot.
@willmmiles do you know which settings or combinations are critical in this regard?</issue_description>

<agent_instructions>check current code, issuing a reboot from the web client is already implemented, so it the same way.
add a variable "busChanged" to the led settings page which is set to true a bus is added or a bus type is changed. when saving the led settings, inform the user that a reboot is required, let the user decide to proceed or cancel. </agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #4958

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: DedeHai <[email protected]>

DedeHai

fix this.

DedeHai · 2025-09-28T10:49:10Z

wled00/data/settings_leds.htm

+		function checkBusChanges() {
+			// check if bus configuration has changed
+			let buses = d.Sf.querySelectorAll("#mLC select[name^=LT]");
+			let currentBusCount = buses.length;


this is redundant, if bus count increases, the below check for value will catch it

Removed the redundant bus count check. The bus type comparison now catches both type changes and additions/removals. Fixed in commit 7dba246.

DedeHai · 2025-09-28T10:49:35Z

wled00/data/settings_leds.htm

+
+			// check if any bus type changed
+			for (let i = 0; i < buses.length; i++) {
+				if (parseInt(buses[i].value) != originalBusTypes[i]) {


exempt virtual and network buses

Added exemption for virtual and network buses using isVir() and isNet() functions. These buses are hardware-independent and don't require reboot. Fixed in commit 7dba246.

DedeHai · 2025-09-28T10:50:20Z

wled00/data/settings_leds.htm

+			// check for bus changes that require reboot
+			checkBusChanges();
+			if (busChanged) {
+				var msg = "LED hardware configuration changed. A reboot is required for changes to take effect.\n\nDo you want to continue and reboot after saving?";


shorten the string but keep the meaning.

Shortened the confirmation message to "LED hardware changed. Reboot required to apply changes.\n\nContinue and reboot after saving?" while keeping the meaning clear. Fixed in commit 7dba246.

DedeHai · 2025-09-28T10:52:42Z

@copilot please fix the review comments.

…tual/network buses, shorten dialog message Co-authored-by: DedeHai <[email protected]>

Copilot · 2025-09-28T10:59:06Z

@copilot please fix the review comments.

All review comments have been addressed in commit 7dba246:

Removed redundant bus count check
Exempted virtual/network buses from reboot requirement
Shortened confirmation dialog message

DedeHai · 2025-09-28T12:41:21Z

@copilot originalBusCount is now unused

Co-authored-by: DedeHai <[email protected]>

Copilot · 2025-09-28T12:45:10Z

@copilot originalBusCount is now unused

...

Removed the unused originalBusCount variable. Only tracking originalBusTypes array is needed since bus type comparison handles both type changes and bus additions/removals. Fixed in commit 666df74.

DedeHai · 2025-10-22T06:21:01Z

#5014 properly fixes this.

Initial plan

ab6407d

Copilot AI assigned Copilot and DedeHai Sep 28, 2025

Copilot started work on behalf of DedeHai September 28, 2025 06:26 View session

Remove bus type restrictions and add reboot handling for LED settings

6fba6f7

Co-authored-by: DedeHai <[email protected]>

Copilot AI changed the title ~~[WIP] Reboot instead of restricting LED-type change with multiple buses~~ Remove bus type restrictions and add reboot handling for LED settings Sep 28, 2025

Copilot AI requested a review from DedeHai September 28, 2025 06:49

Copilot finished work on behalf of DedeHai September 28, 2025 06:49

DedeHai reviewed Sep 28, 2025

View reviewed changes

Copilot started work on behalf of DedeHai September 28, 2025 10:52 View session

Address review comments: remove redundant bus count check, exempt vir…

7dba246

…tual/network buses, shorten dialog message Co-authored-by: DedeHai <[email protected]>

Copilot AI requested a review from DedeHai September 28, 2025 10:59

Copilot finished work on behalf of DedeHai September 28, 2025 10:59

Copilot started work on behalf of DedeHai September 28, 2025 12:41 View session

Remove unused originalBusCount variable

666df74

Co-authored-by: DedeHai <[email protected]>

Copilot finished work on behalf of DedeHai September 28, 2025 12:45

DedeHai closed this Oct 22, 2025

Uh oh!

Remove bus type restrictions and add reboot handling for LED settings #4964

Remove bus type restrictions and add reboot handling for LED settings #4964

Uh oh!

Conversation

Copilot AI commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixed Bus Type Change Restrictions with Reboot Handling

Changes Completed:

Technical Details:

User Experience:

Comments on the Issue (you are @copilot in this section)

Uh oh!

DedeHai left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DedeHai Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

DedeHai Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

DedeHai Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

DedeHai commented Sep 28, 2025

Uh oh!

Copilot AI commented Sep 28, 2025

Uh oh!

DedeHai commented Sep 28, 2025

Uh oh!

Copilot AI commented Sep 28, 2025

Uh oh!

DedeHai commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Sep 28, 2025 •

edited

Loading

DedeHai left a comment •

edited

Loading