Replace window timer with injected timer #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirke
approved these changes
Oct 31, 2024
test/components/BannerConductor/StateMachine/states/PendingState.spec.ts
Outdated
Show resolved
Hide resolved
Abban
force-pushed
the
timer
branch
2 times, most recently
from
6418d97
to
c27677e
Compare
Abban
force-pushed
the
timer
branch
2 times, most recently
from
05af049
to
70405d7
Compare
moiikana
requested changes
Nov 7, 2024
|
Good catch, thanks. |
gbirke
requested changes
Nov 7, 2024
| @@ -27,6 +27,7 @@ import { LocaleFactoryDe } from '@src/utils/LocaleFactory/LocaleFactoryDe'; | |||
| import { createFormItems } from './form_items'; | |||
| import { createFormActions } from '@src/createFormActions'; | |||
| import { currentCampaignTimePercentage } from './currentCampaignTimePercentage'; | |||
| import { WindowTimer } from '@src/utils/Timer'; | |||
There was a problem hiding this comment.
Could you move these imports up in all banners (both WindowTimer and currentCampaignTimePercentage, to avoid misleading comments?
There was a problem hiding this comment.
I think I'd rather remove the comments, the IDE auto imports are always gonna mess this up
|
I just discovered that there is one more change needed - injecting the timer in the WPDE banners |
Components that use timers are hard to test. This removed the window timers and replaces them with an interface that we can mock. Updates all tests and banners to use the new timer. Ticket: https://phabricator.wikimedia.org/T378589
We previously tried to separate the imports in the banner entry points into logical sections. This didn't work well with IDE auto adding them at the bottom each time a new object was added. It was also a little confusing as to what should go where. This removes the comments and embraces js import chaos. Ticket: https://phabricator.wikimedia.org/T378589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components that use timers are hard to test. This
removed the window timers and replaces them with
an interface that we can mock.
Ticket: https://phabricator.wikimedia.org/T378589