C24_WMDE_Desktop_DE_11 #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abban
force-pushed
the
C24_WMDE_Desktop_DE_11
branch
2 times, most recently
from
5c86fc0
to
2c7ae57
Compare
Sperling-0
approved these changes
Nov 8, 2024
Based on CTRL of test 10 Banners are hidden under 800px Ticket: https://phabricator.wikimedia.org/T379246
Abban
force-pushed
the
C24_WMDE_Desktop_DE_11
branch
from
2c7ae57
to
58c89bc
Compare
VAR has the double progress bar Ticket: https://phabricator.wikimedia.org/T379246
Abban
force-pushed
the
C24_WMDE_Desktop_DE_11
branch
from
58c89bc
to
6f01d14
Compare
- making this a global change because we can often assume that progress bars behave the same in all channels https://phabricator.wikimedia.org/T379246#10304195
Sperling-0
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the CRTL of test 10
VAR has the double progress bar
https://phabricator.wikimedia.org/T379539