Fix EC public key auto-derive version check for OpenSSL 4.0.0+ #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EC public key auto-derivation feature (deriving public key from private key during fromdata()) was merged to OpenSSL master on Dec 15, 2025 via PR #29054. This feature will be in OpenSSL 4.0.0, not 3.6.x as previously assumed. The original version check `> 0x30600000L` incorrectly triggered for OpenSSL 3.6.x which does not have this feature, causing test_ec_import to fail because wolfProvider was auto-deriving public keys while OpenSSL 3.6.x was not. Changes: - Update version check from `> 0x30600000L` to `>= 0x40000000L` - Update comments to reference the actual OpenSSL PR - Clean up test code structure See: openssl/openssl#29054 Co-Authored-By: Claude Opus 4.5 <[email protected]>
padelsbach
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EC public key auto-derivation feature (deriving public key from private key during fromdata()) was merged to OpenSSL master on Dec 15, 2025 via PR #29054. This feature will be in OpenSSL 4.0.0, not 3.6.x as previously assumed.
The original version check
> 0x30600000Lincorrectly triggered for OpenSSL 3.6.x which does not have this feature, causing test_ec_import to fail because wolfProvider was auto-deriving public keys while OpenSSL 3.6.x was not.Changes:
> 0x30600000Lto>= 0x40000000LSee: openssl/openssl#29054