Scene “Rough Assembly” preview & Video Player #3
+753
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add video player controller js - add xstate - refactor "best take" query
- show elapsed time of total playlist duration - use data-action for event handling (ended, timeupdate)
- don't use CSS transition to animate - update periodically via JavaScript - can set period via VideoPlayer.UPDATE_INTERVAL_MS
- determine duration of downloaded RTSP file once complete - patch metadata_json - takes.metadata_json can't be NULL - initialize takes.metadata_json object when take is created - add rtsp-client test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Rough Assembly preview is a sequence of the “best” Takes for each Shot in a Scene.
The “best” Take is the highest-rated, most recent take for a Shot.
If a Take hasn’t been downloaded yet, it is skipped when preparing the list of "best" Takes.
If no "best" Takes are present, the Video Player is hidden, and a “Not Available” notice is shown.
Users can view the Rough Assembly preview for a Scene from the Scene Detail page.
Tasks
Future Work
preview.json) instead of inline HTML data for use by other tools.ffprobeto calculate for each rough assembly take on every visit to scene detail page)