-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Order filtering] Filtering orders by product screen contains a filter button that is broken #12643
base: trunk
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
@@ -397,7 +397,7 @@ | |||
android:name="productId" | |||
app:argType="long" /> | |||
<argument | |||
android:name="allowedVatiations" | |||
android:name="allowedVariations" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo fix.
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…roduct-screen-contains-a-filter-button-that-is-broken
Found 1 violations: The PR caused the following dependency changes:expand
-+--- androidx.databinding:viewbinding:8.5.1
++--- androidx.databinding:viewbinding:8.4.0
+--- project :libs:cardreader
| \--- com.stripe:stripeterminal-localmobile:3.7.1
-| \--- androidx.databinding:viewbinding:8.2.2 -> 8.5.1 (*)
+| \--- androidx.databinding:viewbinding:8.2.2 -> 8.4.0 (*)
\--- org.wordpress:mediapicker:0.3.1
- \--- androidx.databinding:viewbinding:8.1.0 -> 8.5.1 (*)
+ \--- androidx.databinding:viewbinding:8.1.0 -> 8.4.0 (*)
Please review and act accordingly
|
…roduct-screen-contains-a-filter-button-that-is-broken
Version |
Version |
Version |
Version |
Closes: #12623
Description
Addresses an issue where the filter button on the product selection screen is non-responsive. The problem was due to the navigation action not being correctly recognized.
Steps to reproduce
Expected Behavior:
Testing information
Devices Used: tablet emulator
Affected Areas:
The tests that have been performed
Verified the navigation works as expected for the filter button.
Ensured dark mode compatibility for the filter screen.
Conducted smoke tests to confirm no regressions in navigation flow.
I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: