Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Order filtering] Filtering orders by product screen contains a filter button that is broken #12643

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

backwardstruck
Copy link
Contributor

@backwardstruck backwardstruck commented Sep 18, 2024

Closes: #12623

Description

Addresses an issue where the filter button on the product selection screen is non-responsive. The problem was due to the navigation action not being correctly recognized.

Steps to reproduce

  1. Go to the Orders tab.
  2. Click on the Filters option.
  3. Select Products from the filter options.
  4. Click the Filter button on the product selection screen.

Expected Behavior:

  • The filter button should open the product selection filter screen with options for stock status, product status, product type, and product category.

Testing information

Devices Used: tablet emulator

Affected Areas:

  • Product Selection Screen

The tests that have been performed

  • Verified the navigation works as expected for the filter button.

  • Ensured dark mode compatibility for the filter screen.

  • Conducted smoke tests to confirm no regressions in navigation flow.

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@backwardstruck backwardstruck added the type: bug A confirmed bug. label Sep 18, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 18, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit5e7b4ca
Direct Downloadwoocommerce-wear-prototype-build-pr12643-5e7b4ca.apk

@@ -397,7 +397,7 @@
android:name="productId"
app:argType="long" />
<argument
android:name="allowedVatiations"
android:name="allowedVariations"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 18, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit5e7b4ca
Direct Downloadwoocommerce-prototype-build-pr12643-5e7b4ca.apk

…roduct-screen-contains-a-filter-button-that-is-broken
@backwardstruck backwardstruck added this to the 20.6 milestone Sep 20, 2024
@wpmobilebot
Copy link
Collaborator

Found 1 violations:

The PR caused the following dependency changes:

expand

-+--- androidx.databinding:viewbinding:8.5.1
++--- androidx.databinding:viewbinding:8.4.0
 +--- project :libs:cardreader
 |    \--- com.stripe:stripeterminal-localmobile:3.7.1
-|         \--- androidx.databinding:viewbinding:8.2.2 -> 8.5.1 (*)
+|         \--- androidx.databinding:viewbinding:8.2.2 -> 8.4.0 (*)
 \--- org.wordpress:mediapicker:0.3.1
-     \--- androidx.databinding:viewbinding:8.1.0 -> 8.5.1 (*)
+     \--- androidx.databinding:viewbinding:8.1.0 -> 8.4.0 (*)

Please review and act accordingly

@backwardstruck backwardstruck added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Sep 20, 2024
…roduct-screen-contains-a-filter-button-that-is-broken
@wpmobilebot wpmobilebot modified the milestones: 20.6, 20.7 Sep 27, 2024
@wpmobilebot
Copy link
Collaborator

Version 20.6 has now entered code-freeze, so the milestone of this PR has been updated to 20.7.

@wpmobilebot wpmobilebot modified the milestones: 20.7, 20.8 Oct 11, 2024
@wpmobilebot
Copy link
Collaborator

Version 20.7 has now entered code-freeze, so the milestone of this PR has been updated to 20.8.

@wpmobilebot wpmobilebot modified the milestones: 20.8, 20.9 Oct 18, 2024
@wpmobilebot
Copy link
Collaborator

Version 20.8 has now entered code-freeze, so the milestone of this PR has been updated to 20.9.

@wpmobilebot wpmobilebot modified the milestones: 20.9, 21.0 Oct 25, 2024
@wpmobilebot
Copy link
Collaborator

Version 20.9 has now entered code-freeze, so the milestone of this PR has been updated to 21.0.

@JorgeMucientes JorgeMucientes removed this from the 21.0 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: do not merge Dependent on another PR, ready for review but not ready for merge. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Order filtering] Filtering orders by product screen contains a filter button that is broken
4 participants