This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Block Hooks: Auto insert the Mini Cart block into the themes header template part#11720
Draft
tjcafferkey wants to merge 2 commits into
Draft
Block Hooks: Auto insert the Mini Cart block into the themes header template part#11720tjcafferkey wants to merge 2 commits into
tjcafferkey wants to merge 2 commits into
Conversation
…using Block Hooks
tjcafferkey
added
type: enhancement
Contributor
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Contributor
|
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
Contributor
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
Bot
added
the
status: stale
github-actions
Bot
removed
the
status: stale
Contributor
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
Bot
added
the
status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXPERIMENTAL: DO NOT MERGE
What
Automatically inserts the Mini Cart block into the themes header template part
Fixes #
Why
Most online stores have a mini cart in the headers, auto inserting this means that the merchant doesn't have to do this himself.
You are able to insert this via
block.jsonand specifying thecore/navigationblock as the anchor block but the problem with that approach is that everywhere that block is used we will auto insert the Mini Cart. Using this approach we can be a bit more specific and just target thecore/navigationblock in the themes header template part.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog