Open
Conversation
Annoyingly strict warnings
why do we even have `/WX` compilation checking?
I should probably go install that prehook again
wopss
reviewed
Jan 21, 2026
Owner
wopss
left a comment
wopss
left a comment
There was a problem hiding this comment.
I'm fine with this change, but I'm thinking about the impact. There are many libs that use the old name. @jackhumbert @maximegmd @psiberx what do you think?
Also, the directory name doesn't match the namespace, not sure if we should rename the directory to rtti or Rtti and just have an exception.
Contributor
|
Looks good to me! |
wopss
requested changes
Jan 26, 2026
include/RED4ext/RTTITypes.hpp
Outdated
| { | ||
| Construct(aMemory); | ||
| } | ||
| using ERTTIType = rtti::ERTTIType; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first in a series of requests aiming to improve the implementation and accuracy of RTTI types
Changes are to be split across multiple requests for better digestibility and finer grained tweaking