Add navigation abstraction layer to `EditPostActivity` #22067

oguzkocer · 2025-07-29T23:16:19Z

Summary

Replaces direct ViewPager manipulation with a testable navigation abstraction layer.

Changes

EditPostDestination: Type-safe sealed class for navigation targets
EditPostNavigationViewModel: Centralized navigation state with LiveData
EditPostNavigator: Interface for future implementation flexibility
Integration: Updated EditPostActivity to use navigation abstraction
Tests: Comprehensive unit tests covering all navigation scenarios

Benefits

Navigation logic is now testable and centralized
Maintains full backward compatibility with existing ViewPager
Enables future migration to ViewPager2/Navigation Component
Clear separation between navigation logic and UI concerns

Testing Instructions

Open EditPostActivity and navigate between Editor/Settings/PublishSettings/History tabs
Verify back navigation works correctly (PublishSettings → Settings → Editor)
Confirm menu items show/hide appropriately based on current tab
Test that UI updates (titles, toolbar styling) work as before

- EditPostDestination: Type-safe sealed class for navigation destinations - EditPostNavigator: Interface for navigation implementation abstraction - Provides foundation for replacing ViewPager with flexible navigation

- Manages navigation state and events using LiveData - Provides navigateTo() method accepting destination enum - Handles back navigation logic with proper fallback hierarchy - Includes debugging logs for navigation flow tracking - Uses EditPostDestination.default() for type-safe fallbacks

- Tests all navigation methods and state transitions - Covers complete user journey flows (Editor → Settings → PublishSettings) - Verifies event emission for UI updates - Tests edge cases like back navigation from Editor - Ensures proper fallback behavior and type safety - 11 test scenarios with 100% navigation logic coverage

- Set up navigation state observers to update ViewPager position and UI - Replace direct ViewPager.currentItem assignments with editPostNavigationViewModel.navigateTo() - Update back navigation logic to use navigation ViewModel with proper fallback - Update menu visibility logic to use navigation state instead of ViewPager position - Add helper methods updateViewPagerPosition() and updateUIForDestination() - Maintain existing ViewPager functionality while adding navigation abstraction layer

- Remove onPageSelected callback that was duplicating UI updates - Fix History destination to use correct liftOnScrollTargetViewId (empty_recycler_view) - UI updates now handled exclusively by navigation system in updateUIForDestination() - ViewPager is now purely for content display, not navigation state management

wpmobilebot · 2025-07-29T23:31:33Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22067-579b8fa
	Commit	`579b8fa`
	Direct Download	`wordpress-prototype-build-pr22067-579b8fa.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2025-07-29T23:34:38Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22067-579b8fa
	Commit	`579b8fa`
	Direct Download	`jetpack-prototype-build-pr22067-579b8fa.apk`

Note: Google Login is not supported on these builds.

sonarqubecloud · 2025-07-29T23:40:05Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-07-29T23:55:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.29%. Comparing base (ce4aa0a) to head (579b8fa).
⚠️ Report is 2 commits behind head on trunk.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #22067   +/-   ##
=======================================
  Coverage   39.29%   39.29%           
=======================================
  Files        2143     2143           
  Lines      101698   101698           
  Branches    15597    15597           
=======================================
  Hits        39958    39958           
  Misses      58187    58187           
  Partials     3553     3553

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nbradbury · 2025-07-30T11:59:09Z

WordPress/src/main/java/org/wordpress/android/ui/posts/navigation/EditPostNavigator.kt

+ * Interface for handling navigation between different screens in the Edit Post flow.
+ * Provides abstraction over the underlying navigation implementation.
+ */
+interface EditPostNavigator {


AS says this interface is unused, which I confirmed by deleting it and successfully building the app. Is there a reason to keep this?

This abstraction happened a little early in the process. I'll remove it in #22068 and re-add it when we need it. Sorry for the confusion!

Addressed in eae9287 in #22068.

nbradbury · 2025-07-30T12:01:39Z

WordPress/src/main/java/org/wordpress/android/ui/posts/navigation/EditPostDestination.kt

+    /**
+     * The main editor screen where users write and edit post content.
+     */
+    object Editor : EditPostDestination()


NP: AS recommends converting these objects into data objects.

Interesting that my AS doesn't 😕

Addressed in 662b71a in #22068.

nbradbury

@oguzkocer Code looks and works fine. I left a couple of comments, but it's up to you whether they're worth addressing so I'll approve this. I do recommend asking Copilot for a review in future PRs - it usually does a great job finding issues.

Update: Well, I hadn't noticed that auto-merge was enabled, so I guess if you want to address those comments you can do so in a subsequent PR.

oguzkocer added 5 commits July 29, 2025 18:55

Add navigation contracts for Edit Post flow

0761f90

- EditPostDestination: Type-safe sealed class for navigation destinations - EditPostNavigator: Interface for navigation implementation abstraction - Provides foundation for replacing ViewPager with flexible navigation

oguzkocer added this to the 26.1 milestone Jul 29, 2025

oguzkocer added the Posting/Editing label Jul 29, 2025

Remove unused import SimpleOnPageChangeListener

579b8fa

oguzkocer marked this pull request as ready for review July 29, 2025 23:58

oguzkocer enabled auto-merge (squash) July 29, 2025 23:58

oguzkocer requested review from adalpari and nbradbury July 30, 2025 00:18

nbradbury self-assigned this Jul 30, 2025

nbradbury reviewed Jul 30, 2025

View reviewed changes

nbradbury approved these changes Jul 30, 2025

View reviewed changes

oguzkocer merged commit 43b0fb7 into trunk Jul 30, 2025
27 checks passed

oguzkocer deleted the feature/edit-post-navigation-abstraction branch July 30, 2025 12:14

oguzkocer mentioned this pull request Jul 31, 2025

feat: Authenticate protected media requests on private sites #22047

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add navigation abstraction layer to `EditPostActivity` #22067

Add navigation abstraction layer to `EditPostActivity` #22067

Uh oh!

oguzkocer commented Jul 29, 2025

Uh oh!

wpmobilebot commented Jul 29, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 29, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Jul 29, 2025

Uh oh!

codecov bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

nbradbury Jul 30, 2025

Uh oh!

oguzkocer Jul 30, 2025

Uh oh!

oguzkocer Jul 30, 2025

Uh oh!

nbradbury Jul 30, 2025

Uh oh!

oguzkocer Jul 30, 2025

Uh oh!

nbradbury left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Add navigation abstraction layer to EditPostActivity #22067

Add navigation abstraction layer to EditPostActivity #22067

Uh oh!

Conversation

oguzkocer commented Jul 29, 2025

Summary

Changes

Benefits

Testing Instructions

Uh oh!

wpmobilebot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 29, 2025

Quality Gate passed

Uh oh!

codecov bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nbradbury Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

oguzkocer Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

oguzkocer Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

nbradbury Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

oguzkocer Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

nbradbury left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Add navigation abstraction layer to `EditPostActivity` #22067

Add navigation abstraction layer to `EditPostActivity` #22067

wpmobilebot commented Jul 29, 2025 •

edited

Loading

wpmobilebot commented Jul 29, 2025 •

edited

Loading

codecov bot commented Jul 29, 2025 •

edited

Loading

nbradbury left a comment •

edited

Loading