refactor: Remove unused Jetpack global configuration #22166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration is now unnecessary, as the relevant globals were replaced with new globals. The new globals are set via remote JavaScript loaded into the WebView rather than manually setting the globals via GutenbergKit configuration. - Removal: Automattic/jetpack#44133 - New globals: Automattic/jetpack#44077
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22166-59e4ba4 | |
| Commit | 59e4ba4 | |
| Direct Download | jetpack-prototype-build-pr22166-59e4ba4.apk |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22166-59e4ba4 | |
| Commit | 59e4ba4 | |
| Direct Download | wordpress-prototype-build-pr22166-59e4ba4.apk |
Project dependencies changeslist! Upgraded Dependencies
org.wordpress.gutenbergkit:android:v0.8.0-alpha.2, (changed from v0.8.0-alpha.0)tree +--- project :libs:editor
-| \--- org.wordpress.gutenbergkit:android:v0.8.0-alpha.0
+| \--- org.wordpress.gutenbergkit:android:v0.8.0-alpha.2
-\--- org.wordpress.gutenbergkit:android:v0.8.0-alpha.0 (*)
+\--- org.wordpress.gutenbergkit:android:v0.8.0-alpha.2 (*) |
dcalhoun
requested review from
adalpari and
nbradbury
and removed request for
a team
|
@nbradbury #22165 stacks upon this pull request. To save time, you might perform any testing on builds of #22165. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This configuration is now unnecessary, as the relevant globals were replaced with new globals. The new globals are set via remote JavaScript loaded into the WebView rather than manually setting the globals via GutenbergKit configuration.
Related:
Testing instructions