Skip to content

Fixes #1003 Remove esc_html() when outputting data with HTML #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mai-Saad merged 2 commits into from
Jan 8, 2026
Merged

Fixes #1003 Remove esc_html() when outputting data with HTML #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3616c2
remove esc_html() when outputting data with HTML
remyperona Jan 6, 2026
e474232
remove extra space
remyperona Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions views/input/selector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
<div class="imagify-selector">
<span class="hide-if-js">
<?php echo esc_html( $data['current_label'] ); ?>
<span class="imagify-selector-current-value-info"><?php echo esc_html( $data['values'][ $data['value'] ] ); ?></span>
<span class="imagify-selector-current-value-info"><?php echo $data['values'][ $data['value'] ]; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></span>
</span>

<button aria-controls="<?php echo esc_attr( $list_id ); ?>" type="button" class="button imagify-button-clean hide-if-no-js imagify-selector-button">
<span class="imagify-selector-current-value-info"><?php echo esc_html( $data['values'][ $data['value'] ] ); ?></span>
<span class="imagify-selector-current-value-info"><?php echo $data['values'][ $data['value'] ]; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></span>
</button>

<ul id="<?php echo esc_attr( $list_id ); ?>" role="listbox" aria-orientation="vertical" aria-hidden="true" class="imagify-selector-list hide-if-no-js">
Expand All @@ -38,7 +38,7 @@
?>
<li class="imagify-selector-choice<?php echo $val === $data['value'] ? ' imagify-selector-current-value" aria-current="true' : ''; ?>" role="option">
<input type="radio" name="<?php echo esc_attr( $data['name'] ); ?>" value="<?php echo esc_attr( $val ); ?>" id="<?php echo esc_attr( $input_id ); ?>" <?php checked( $val, $data['value'] ); ?> class="screen-reader-text">
<label for="<?php echo esc_attr( $input_id ); ?>"><?php echo esc_html( $label ); ?></label>
<label for="<?php echo esc_attr( $input_id ); ?>"><?php echo $label; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></label>
Comment thread
remyperona marked this conversation as resolved.
</li>
<?php
}
Expand Down
8 changes: 4 additions & 4 deletions views/part-bulk-optimization-table-row-folder-type.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
<label for="cb-select-<?php echo esc_attr( $data['group_id'] ); ?>"><?php echo esc_html( $data['title'] ); ?></label>
</td>
<td class="imagify-cell-count-optimized">
<?php echo esc_html( $data['count-optimized'] ); ?>
<?php echo $data['count-optimized']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
</td>
<td class="imagify-cell-count-errors">
<?php echo esc_html( $data['count-errors'] ); ?>
<?php echo $data['count-errors']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
</td>
<td class="imagify-cell-optimized-size-size">
<?php echo esc_html( $data['optimized-size'] ); ?>
<?php echo $data['optimized-size']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
</td>
<td class="imagify-cell-original-size-size">
<?php echo esc_html( $data['original-size'] ); ?>
<?php echo $data['original-size']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
</td>
<td class="imagify-cell-level">
<?php
Expand Down
Loading