Fixes #984 Make settings page checkboxes clickable again

[remyperona]

Description

Fixes #984

Fix the issue where the settings page checkboxes are unclickable in the 2.2.6 first test round

Type of change

• Bug fix (non-breaking change which fixes an issue).

Detailed scenario

What was tested

Tested checking/unchecking checkboxes on Imagify settings page

How to test

Go on Imagify settings page, and try to check/uncheck the checkboxes

Technical description

Documentation

The issue happened because of extra spacing in the HTML attributes, following some fixes for PHP CodeSniffer. This caused the label and input to not match anymore.

Mandatory Checklist

Code validation

• I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Code style

• I wrote a self-explanatory code about what it does.
• I protected entry points against unexpected inputs.
• I did not introduce unnecessary complexity.
• Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

Can't add tests for this output

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.00% (target: -0.10%)	❌ 0.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (210c463)	14315	48	0.34%
Head commit (ec7f845)	14224 (-91)	48 (+0)	0.34% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#986)	31	0	0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

[wordpressfan]

It's working as expected but I'm wondering why don't we escape the attributes using esc_attr or something similar instead of just echo them?

I'm approving them because this was the case already there before.

[remyperona]

It will be managed in a different PR when tackling #972, I avoided doing too many changes at the same time