Fixes #32 Remove files from export#34
Open
remyperona wants to merge 7 commits intotrunkfrom
Open
Conversation
* make first version works * use correct js file * remove not needed changes * play with gitattributes * try changing the location of assets * restructuring the assets * check if imagify is activated or not * try install and activate imagify with button click * try admin-ajax * add preloader and redirect in new tab * try inserting the content via JS * add code for block editor * change the admin.js code to make it works * add template with the correct HTML * start adding the style.css * add styles * adjust admin script to handle the install process * add the missed image * adjust the code and fix minor bugs * fix css * fix all phpcs * add the assets php files into ignore * Update assets-src/js/admin.js for code review change Co-authored-by: Gaël Robin <robin.gael@gmail.com> * add the version as a property to be easily changed * fix styling * Set imagify partner * fix post install code to use the correct files * make it more dynamic * use wp_add_inline_script instead of wp_localize_script * check if the GET index has a value before moving forward * fix phpcs * fixed comments from Hanna * Fixed conflict changes --------- Co-authored-by: Gaël Robin <robin.gael@gmail.com> Co-authored-by: Michael Lee <michaelleemichaellee408@gmail.com>
…r imagify activation
* add close button into media uploader * add the missed button * remove the promote imagify notice correctly * build assets again * fix phpcs * adjust close button size * add the button also for the image block * fix the close button size * change the version 1.0.6 before releasing
# Conflicts: # src/assets/js/admin.js
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s export configuration so that development/build artifacts are excluded from distribution archives (e.g., Composer/GitHub “dist” installs), aligning with issue #32’s goal of reducing security scanner noise from non-production files.
Changes:
- Mark
webpack.config.jsasexport-ignorein.gitattributes. - Mark
package-lock.jsonasexport-ignorein.gitattributes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #32
Remove
package-lock.jsonandwebpack.config.jsfrom production filesType of change
Detailed scenario
What was tested
Files are not present anymore when exporting the library (through composer for example)
How to test
Use branch
dev-fix/32-package-lockas version for the plugin family in composer file. Check the files are not present in the folderAffected Features & Quality Assurance Scope
No feature affected directly
Technical description
Documentation
This PR updates the project’s export configuration so that development/build artifacts are excluded from distribution archives (e.g., Composer/GitHub “dist” installs), aligning with issue #32’s goal of reducing security scanner noise from non-production files.
Mandatory Checklist
Code validation
Code style
Unticked items justification
Not applicable for this PR