Skip to content

Closes #947 Test onboarding settings#233

Merged
Khadreal merged 28 commits into
developfrom
feature/947-test-onboarding-settings
Jun 26, 2025
Merged

Closes #947 Test onboarding settings#233
Khadreal merged 28 commits into
developfrom
feature/947-test-onboarding-settings

Conversation

@Khadreal
Copy link
Copy Markdown
Contributor

Description

Fixes (https://github.com/wp-media/backwpup-pro/issues/947)

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Chore
  • Release

Detailed scenario

Check the issue

What was tested

Unchecked options during onboarding and confirm the settings were as it-is after onboarding.

How to test

Run the command npm run test:bwpupsmoke

Technical description

Documentation

Add new scenarios and steps

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

n/a

@Khadreal Khadreal requested a review from a team June 24, 2025 13:51
@Khadreal Khadreal self-assigned this Jun 24, 2025
@Khadreal
Copy link
Copy Markdown
Contributor Author

Screenshot 2025-06-25 at 13 08 07

jeawhanlee
jeawhanlee previously approved these changes Jun 26, 2025
@jeawhanlee jeawhanlee dismissed their stale review June 26, 2025 08:29

Found something, need to ask a question.

Comment thread src/common/custom-world.ts Outdated
@Khadreal Khadreal requested a review from jeawhanlee June 26, 2025 09:56
@Khadreal Khadreal merged commit 8a2015b into develop Jun 26, 2025
2 checks passed
@Khadreal Khadreal deleted the feature/947-test-onboarding-settings branch June 26, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants