fixed problem when tests are not failing when backup fails (form 5.6.8)#373
Merged
fixed problem when tests are not failing when backup fails (form 5.6.8)#373
Conversation
…8 failed backups are added to the history list)
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes BackWPup E2E assertions so scenarios fail when any backup in history is marked as failed (behavior introduced in BackWPup 5.6.8), instead of only validating the backup count.
Changes:
- Extend captured backup-history row data with a
failedflag and fail the scenario when any failed backup is detected. - Improve backup-history table parsing by normalizing multi-line cell text and extracting the meaningful value from responsive/hidden text.
- Add Node version/tooling metadata (
engines,.nvmrc) and update BackWPup feature tags.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/backwpup/utils/types.ts |
Adds failed to BackupRowData for richer backup-history assertions. |
src/backwpup/utils/helpers.ts |
Adds text-normalization helpers used to parse responsive BackWPup table cells reliably. |
src/backwpup/steps/general.ts |
Detects failed backups from the history table and fails the test before validating row-count expectations. |
src/backwpup/features/backup.feature |
Adds an additional tag for the backup feature. |
package.json |
Declares a Node engine constraint. |
.vscode/settings.json |
Adds a workspace TypeScript SDK setting (currently using an invalid key). |
.nvmrc |
Pins a Node version for local development. |
Miraeld
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks if any backup failed before checking if the number of expected backups matches.
In case any backup failed, it will mark the test as failed as well, fixing the original issue.
Description
Fixes #372
Type of change
Detailed scenario
What was tested
Ran tests with failed backups and ran the whole suite of tests to guarantee no regressions.
When a failed backup is found in the result:
All tests ran (no failed backups):

How to test
Simulate an scenario in which a backup would fail and run a test with this step:
'x' backup is generated and added to historyAffected Features & Quality Assurance Scope
Tests that check if the backup number matches with the expected number.
Technical description
Documentation
Checking for the word "failed" in the 4th column (the one in which text
Backup failedis displayed), and if the text is found, then the backup is marked as failed and then simply throws an error (fails the test) if any backup is marked as failed.New dependencies
N/A
Risks
N/A
Mandatory Checklist
Code validation
Code style