Skip to content

Exclude cdn iframe URL from broken links test#376

Merged
Mai-Saad merged 1 commit intodevelopfrom
fix/exclude-cdn-iframe-URL-from-broken-links-test
Apr 22, 2026
Merged

Exclude cdn iframe URL from broken links test#376
Mai-Saad merged 1 commit intodevelopfrom
fix/exclude-cdn-iframe-URL-from-broken-links-test

Conversation

@Mai-Saad
Copy link
Copy Markdown
Contributor

@Mai-Saad Mai-Saad commented Apr 22, 2026

Description

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Chore
  • Release

Detailed scenario

What was tested

  • Run broken test => pass
  • Smoke test => pass

How to test

As mentioned above

Affected Features & Quality Assurance Scope

  • Broken links test

Technical description

Documentation

  • Just added cdn/iframe to excluded links

New dependencies

N/A

Risks

  • If CDN URL is broken, we won't know from e2e

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

N/A

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@Mai-Saad Mai-Saad added this to the 1.2.3 milestone Apr 22, 2026
@Mai-Saad
Copy link
Copy Markdown
Contributor Author

image

@Mai-Saad Mai-Saad self-assigned this Apr 22, 2026
@Mai-Saad
Copy link
Copy Markdown
Contributor Author

image

@Mai-Saad Mai-Saad merged commit de04d46 into develop Apr 22, 2026
6 of 7 checks passed
@Mai-Saad Mai-Saad deleted the fix/exclude-cdn-iframe-URL-from-broken-links-test branch April 22, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant