Merge pull request #22 from writeas/return-error-on-login-404

Don't return early if we get a 404 on login attempt
writefreely · Oct 6, 2020 · accd9c4 · accd9c4
2 parents 52ea441 + a671f83
commit accd9c4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/Sources/WriteFreely/WFClient.swift b/Sources/WriteFreely/WFClient.swift
@@ -924,7 +924,11 @@ public class WFClient {
                     }
                 } else {
                     // We didn't get a 200 OK, so return a WFError
-                    guard let error = self.translateWFError(fromServerResponse: data) else { return }
+                    guard let error = self.translateWFError(fromServerResponse: data) else {
+                        // We couldn't generate a WFError from the server response data, so return an unknown error.
+                        completion(.failure(WFError.unknownError))
+                        return
+                    }
                     completion(.failure(error))
                 }
             }
@@ -1088,7 +1092,8 @@ private extension WFClient {
             print("⛔️ \(error.message)")
             return WFError(rawValue: error.code)
         } catch {
-            return nil
+            print("⛔️ An unknown error occurred.")
+            return WFError.unknownError
         }
     }
 }
diff --git a/Sources/WriteFreely/WFError.swift b/Sources/WriteFreely/WFError.swift
@@ -12,6 +12,7 @@ public enum WFError: Int, Error {
     case internalServerError = 500
     case badGateway = 502
     case serviceUnavailable = 503
+    case unknownError = -1
 }
 
 struct ErrorMessage: Codable {