Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audience validation support for APIM #12404

Closed
wants to merge 3 commits into from

Conversation

Kirishikesan
Copy link
Contributor

Overview

API authentication with audience restriction in JWT (JSON Web Token) involves ensuring that the token is only accepted by the intended audience or recipients. The audience claim (aud) in a JWT specifies the intended recipients for the token. This PR adds api level audience validation in JWT tokens for api manager.

Resolves

wso2/api-manager#2784

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 57.85714% with 59 lines in your changes missing coverage. Please review.

Project coverage is 46.87%. Comparing base (af47e58) to head (371a2b7).
Report is 364 commits behind head on master.

Files Patch % Lines
...i/publisher/v1/common/mappings/APIMappingUtil.java 51.85% 4 Missing and 9 partials ⚠️
...gt/gateway/handlers/security/jwt/JWTValidator.java 44.44% 8 Missing and 2 partials ⚠️
...t/rest/api/publisher/v1/dto/APIProductInfoDTO.java 22.22% 7 Missing ⚠️
...pimgt/rest/api/publisher/v1/dto/APIProductDTO.java 40.00% 6 Missing ⚠️
...arbon/apimgt/rest/api/publisher/v1/dto/APIDTO.java 44.44% 5 Missing ⚠️
...n/apimgt/rest/api/publisher/v1/dto/APIInfoDTO.java 44.44% 5 Missing ⚠️
...t/api/publisher/v1/common/TemplateBuilderUtil.java 60.00% 2 Missing and 2 partials ⚠️
...ay/handlers/security/APIAuthenticationHandler.java 71.42% 0 Missing and 2 partials ⚠️
...ateway/handlers/security/APISecurityConstants.java 0.00% 2 Missing ⚠️
...on/apimgt/persistence/RegistryPersistenceImpl.java 66.66% 0 Missing and 2 partials ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12404      +/-   ##
============================================
+ Coverage     41.79%   46.87%   +5.07%     
- Complexity        0     4203    +4203     
============================================
  Files          1871     1871              
  Lines        138441   138575     +134     
  Branches      20045    20071      +26     
============================================
+ Hits          57868    64961    +7093     
+ Misses        73570    65859    -7711     
- Partials       7003     7755     +752     
Flag Coverage Δ
integration_tests 41.43% <57.85%> (+6.33%) ⬆️
unit_tests 20.11% <20.38%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RakhithaRR
Copy link
Contributor

Closing this since the feature is added through #12511

@RakhithaRR RakhithaRR closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants