Add changes to add subscription status to application.yaml when exporting and to support ignoreTier query param when importing #12442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting and to support ignoreTier query param when importing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: https://github.com/wso2-support/carbon-apimgt/pull/6447, https://github.com/wso2-support/carbon-apimgt/pull/6451
This PR adds the subscription workflow status to the application.yaml when exporting an application. Please note that although we added the changes to the application.yaml, we haven't considered the status when importing. Need to have a discussion and support preserving the workflow status when importing too. Currently the status is shown as "ON_HOLD" for all 3 types (ON_HOLD, ACCEPTED, REJECTED).
This PR adds a query parameter to the import Rest API call as ''ignoreTier". This is to skip considering whether the subscription tier is available at the API for a particular subscription at the time of importing the application. The default value is false. If the value is set to true, then the tier will not be considered and the import will be done for all the subscriptions. Only an error will be logged saying the particular tier is not available for the subscription of the particular API. If the value is false, default behaviour will be considered and the application will be imported giving a 207 status.