Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parent/pom.xml to fix artifacts not picking the version correctly due to errors in the pom #3293

Merged
merged 2 commits into from
May 23, 2022

Conversation

ratnajothy
Copy link

@ratnajothy ratnajothy commented May 16, 2022

Purpose

Fixing following errors related to version elements in parent/pom.xml

  • Version of poi-ooxml artifact is not picked correctly. Included the defined version property orbit.version.poi.ooxml within ${}, as it was previously missing.
  • Incorrect version property referenced for xmlunit artifact. Referenced the right version property.

Goals

To ensure custom component dependent on this parent/pom.xml do not fail when trying to pull and resolve those artifacts above.

Issue #3296

Changed to <version>${orbit.version.poi.ooxml}</version>, otherwise there is error when pulling the dependency.
@ratnajothy ratnajothy changed the title Update pom.xml to fix poi-ooxml artifact being versioned correctly Update parent/pom.xml to fix artifacts not picking the version correctly due to errors in the pom May 22, 2022
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2369893908

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/2369893908
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/2369893908

@piraveena piraveena merged commit 9e275be into wso2:4.7.x May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants