Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java 21 runtime] Relaxed strong encapsulation to support java 17 runtime #21175

Merged
merged 3 commits into from
Oct 3, 2024
Merged

[Java 21 runtime] Relaxed strong encapsulation to support java 17 runtime #21175

merged 3 commits into from
Oct 3, 2024

Conversation

indeewari
Copy link
Contributor

@indeewari indeewari commented Sep 26, 2024 •
edited
Loading

Related Issue

Some non-critical JDK internals, which are strongly encapsulated, are accessed via reflection for audit purposes. There are two approaches to address this:

  1. Eliminate the use of strongly encapsulated JDK internals accessed through reflection.
  2. Opt for relaxed strong encapsulation.

The choice between these options should be made on a case-by-case basis.

After evaluating backward compatibility, impact areas, and implementation complexity, we have opted for relaxed strong encapsulation for the following modules:

For java.base:

  • sun.security.util
  • java.security
  • sun.security.rsa
  • java.security.cert

@indeewari indeewari mentioned this pull request Sep 26, 2024
Open
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11157320561

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11157320561
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11157320561

@indeewari indeewari changed the title [Java 21 runtime] Relaxed strong encapsulation to support java 21 runtime [Java 21 runtime] Relaxed strong encapsulation to support java 17 runtime Oct 3, 2024
@indeewari indeewari merged commit 55baf74 into wso2:master Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@madurangasiriwardena madurangasiriwardena madurangasiriwardena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@indeewari @jenkins-is-staging @madurangasiriwardena