Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintaining thread safety for class med properties #2207

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Maintaining thread safety for class med properties #2207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions modules/core/src/main/java/org/apache/synapse/mediators/ext/ClassMediator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@
import org.apache.synapse.mediators.MediatorProperty;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

/**
* The class mediator delegates the mediation to a single instance of a specified
Expand All @@ -54,7 +52,7 @@ public class ClassMediator extends AbstractMediator implements ManagedLifecycle
private final List<MediatorProperty> properties = new ArrayList<MediatorProperty>();

/** Contains Dynamic Expressions/not */
private boolean hasContentAwareProperties = false;
private boolean hasDynamicProperties = false;

/**
* Don't use a new instance... do one instance of the object per instance of
Expand Down Expand Up @@ -89,7 +87,7 @@ public boolean mediate(MessageContext synCtx) {
boolean result;

try {
if (hasContentAwareProperties) {
if (hasDynamicProperties) {
synchronized (mediator) {
result = updateInstancePropertiesAndMediate(synCtx);
}
Expand Down Expand Up @@ -144,11 +142,17 @@ public void addProperty(MediatorProperty property) {

public void addAllProperties(List<MediatorProperty> propertyList) {
properties.addAll(propertyList);

for (MediatorProperty property : properties) {
SynapsePath expression = property.getExpression();
if (expression != null && expression.isContentAware()) {
hasContentAwareProperties = true;
// Since expressions such as expression="get-property('...')" or expression="$trp:..." are also dynamic
// and their values can change with each request, we face a potential race condition when these
// expressions alter class mediator instance variables using setters. Given that only one instance of the
// mediator is created and shared among multiple concurrent requests, this shared state can lead to
// inconsistent behavior and data corruption. Therefore, we need to ensure synchronization not only
// when the content is altered but also for each evaluation of these dynamic expressions to maintain
// thread safety and data integrity.
if (expression != null) {
hasDynamicProperties = true;
break;
}
}
Expand Down
Loading