Make pretty printer fail on compilation errors #1095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cokemonkey11
commented
Sep 17, 2025
Cokemonkey11
commented
- Modified PrettyUtils to check for compilation errors before formatting
- Added validation step that runs compiler.checkProg() after parsing
- Throws RuntimeException with error details if compilation errors found
- Added comprehensive test coverage for both valid and invalid code
- Ensures pretty printer fails fast with clear error messages
- Modified PrettyUtils to check for compilation errors before formatting - Added validation step that runs compiler.checkProg() after parsing - Throws RuntimeException with error details if compilation errors found - Added comprehensive test coverage for both valid and invalid code - Ensures pretty printer fails fast with clear error messages Co-authored-by: Ona <[email protected]>
Collaborator
Author
|
As discussed, there's a lot that's directionally wrong about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.