Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flow version so it supports real-time check on VSCode #473

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

WagnerMoreira
Copy link
Contributor

@WagnerMoreira WagnerMoreira commented Nov 7, 2019

Fixes https://github.com/x-team/xp/issues/2014

Description

This update enables Flow real-time code checking. In the current flow-bin version we have the vs-code extensions do not work resulting in Flow server errors.

Checklist

  • set yourself as an assignee
  • set appropriate labels for a PR (In Review or In Progress depending on its status)
  • make sure your code lints (npm run lint)
  • Flow type checks passed (npm run flow)
  • Snapshots tests passed (npm run jest)
  • check cleanup tasks (https://github.com/x-team/xp/labels/cleanup) and take a suitable small one (if exists) in a related area of the current changes
  • once finished with all the changes, you run npm run build command and committed changed files to the branch
  • manually tested the app by running it in several different browsers (Firefox, Chrome, Opera, Safari, MS IE/Edge, etc.) and checked nothing is broken and operates as expected!

Steps to Test or Reproduce

The same steps as we can see in the screenshots below.

Impacted Areas in Application

Every JS file

Screenshots

Using "flow-bin": "^0.61.0" Flow server fails to start on VScode

Screen Shot 2019-11-07 at 8 36 11 AM

Without real-time code checking, the summary variable name is incorrect but we see no errors

Screen Shot 2019-11-07 at 8 38 39 AM

With real-time code checking 🎉 🎉 using "flow-bin": "^0.111.1" (latest)

Screen Shot 2019-11-07 at 8 45 18 AM

@WagnerMoreira
Copy link
Contributor Author

@nicksp there are some warnings when I run npm t as you mentioned, I will investigate and find a fix for them, this is probably the only work to do on this cleanup.

@nicksp
Copy link
Collaborator

nicksp commented Nov 11, 2019

@WagnerMoreira There seems to be a conflict in package.json file. Would you mind resolving that?

@nicksp nicksp changed the title update flow version so it supports real-time check on vs-code Update Flow version so it supports real-time check on VSCode Nov 11, 2019
@WagnerMoreira WagnerMoreira force-pushed the update-flow-version-to-support-real-time-check branch from 3953c20 to 90ecebe Compare November 13, 2019 01:18
@nicksp
Copy link
Collaborator

nicksp commented Nov 13, 2019

@WagnerMoreira Just for the reference, here're failing tests: https://gist.github.com/nicksp/0ad87d9327ec3945ba043d6b39ed8442

Seems like a newer Flow version, stricter checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants