Skip to content

I gained a 50% performance increase by merging rejected changes #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

ActuallyTheOwner
Copy link

I don't know how to code, but please see if this can be made more stable
it is absolutely worth the 1000FPS gain I got
Screenshot from 2025-03-23 15-47-15
Screenshot from 2025-03-23 16-05-06

These changes essentially move rendering from ram to vram
Implement some better culling
other stuff

I combined artdeell, fox2code, and thr3343's pull request

@ActuallyTheOwner
Copy link
Author

Sorry github is making it hard to find the pull request, here are the ones I referenced

Not used / held back
#526
#567

Rejected
#508

@ActuallyTheOwner
Copy link
Author

ActuallyTheOwner commented Mar 23, 2025

Another thing I must mention, if the bug with freezes on opening a menu too fast when first creating a world is the same as what I experienced on older versions of vulkanmod, porting to 1.21.4 would fix that and make the PR more stable

@ActuallyTheOwner
Copy link
Author

I need to correct myself on a bug, it's literally just a freeze when you first create a world

@Haberno
Copy link

Haberno commented Apr 14, 2025

I ran the client on your pr branch the current dev branch was giving me around 3700-3800, from this combined PR it was only 3000 flatworld I most likely have different specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants