Fix PR#17 commit 'misc changes', it broke listing and editing Storage Repositories #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernhard Kaindl <[email protected]>
liulinC
approved these changes
Dec 4, 2023
Collaborator
|
Although we will never run the code with py2, I approve this PR as it has no bad. (and it do fix the issue if it is under py2, in some other way I do not understand) |
|
With Python3, I've tested with all the changes in #20. |
Collaborator
Author
This means that we are testing using different methods. I'll ask a team member what he gets. |
ashwin9390
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this regression which was introduced by #17, commit 5: "Misc changes":
29b1793#diff-7a99a3d0d9dc721b20052fba067d76350ea7734d0f26607afec287ad0a296f7c
In #18 (comment), Andrew said that breaking the Python2 master branch before the Python3 branch works is not and option, therefore fix this first.
With Python3, after all commits from #20 are also applied, XSConsole still says:
Therfore, the situation is clear: Fix Python2 first.