CA-415864: MANAGEMENT_INTERFACE is not cleared in network reset

[minglumlu]

The issue is the "MANAGEMENT_INTERFACE" in /etc/xensource-inventory is not cleared in a networking reset. While the networkd is still trying to read the value of "MANAGEMENT_INTERFACE" as the bridge name. This caused the new network interface was added into the bridge before reset.

[last-genius]

Looking at the xe-network-reset script in xapi on the parallel feature branch, the logic here looks somewhat different: https://github.com/xapi-project/xen-api/blob/feature/host-network-device-ordering/python3/bin/xe-reset-networking (I'm not even talking about the weird if not else construct in bridge = '' if not rename_script_exists else get_bridge_name(device, vlan)). On master, the scripts are practically identical and really easy to compare

Could we bring these scripts in sync? Otherwise it'd be difficult to spot differences from a quick look, and since xsconsole is practically untested, this will slip by

[minglumlu]

Could we bring these scripts in sync?

The fix is to get them in sync in function. Unfortunately both xsconsole and xapi are using own code, and both need to be used for different releases. This introduces many if-else. Once they are forked, these could be eliminated.

If you are referring the condition name "rename_script_exists" vs "interface_rename_dir", I could get them same in this PR.

[changlei-li]

The feature branch is rebased on top of master. You may need also rebase your commits.