Skip to content

Conversation

@gopal-panigrahi
Copy link
Contributor

Adds support for range headers for seeking in streams

fixes #1048

@gopal-panigrahi gopal-panigrahi changed the title feat: add support for seeking in file streams feat: added support for seeking in file streams Oct 24, 2025
@rien333
Copy link
Contributor

rien333 commented Oct 25, 2025

Looks promising, tho I have yet to test this!

I've noticed that you've implemented seeking in your new handleFileContent, and not in handleUriContent.

While not technically required for this PR to work and be beneficial, I think it would be nice to support seeking when dealing with file URIs, too. Though then again, maybe that provides extra challenges.

For the record: Kore will currently go through the handleFileContent code path whenever files are shared from within Kore, but Kore will go through the handleUriContent path whenever Kore is asked to opened files from other apps (e.g. a music player or the photos app).

If you would implement seeking in handleUriContent one could, say, share a .mp3 from a music player app, and then seek within that file stream.

@gopal-panigrahi
Copy link
Contributor Author

Understood, I’ll look into handling it for shared media as well. I wasn’t aware of the share feature, thanks for pointing it out.

@gopal-panigrahi
Copy link
Contributor Author

@rien333, I have tried adding seek support for uri content too. Maybe you can try and let me know if there is any usecase left.

@rien333
Copy link
Contributor

rien333 commented Nov 2, 2025

Think you covered everything! Will not have any time available to test until mid november, tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Seek support when playing Local Files

2 participants