Skip to content

Conversation

@gopal-panigrahi
Copy link
Contributor

Added a toggle in settings (“Show hidden local files”) to hide or display hidden local files.

fixes #1050

@SyncedSynapse
Copy link
Member

Thanks for this, looks good, though i'm not convinced that this should be an option on the global application settings. It is a specific option, that should only be available where it makes sense (in the LocalMediaFileListFragment), and preventing the uncontrolled growth of options in the global settings that will confuse the user, sooner or later.

I would suggest the removal of the option from the global settings and the inclusion on the local menu of LocalMediaFileListFragment. Basically create public void onCreateOptionsMenu(@NonNull Menu menu, MenuInflater inflater) and public boolean onOptionsItemSelected(MenuItem item) there and include the new option.

Similar to what is being done on other fragments, for instance on MovieListFragment.

Hope you understand the reasoning.

@gopal-panigrahi
Copy link
Contributor Author

Yeah, the argument makes sense. I have implemented the options menu in LocalMediaFileListFragment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add option to hide hidden local files in Kore

2 participants