Feature: Support listing/loading profiles #1155
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing shows some more problems which are not completely resolved:
|
|
There are two paths possible Letting the app's cached library views depend on user profileNeeds polling of user profile and has several implications to update the current view in case the user profile was changed. E.g. this would require reloading of the movie list view (and any other cached view) if the user profile changed. Ignore the user profile in the app's cacheThis is more in line with current behaviour. Cache does not take the user profile into account. If the user changes the profile, a manual pull-to-sync might be required to update the views to the new access rights. In this case changing the user profile is treated like a Kodi setting which the app can read and set. |
wutschel
force-pushed
the
feature_profiles
branch
2 times, most recently
from
ccaab5e
to
52d2210
Compare
wutschel
force-pushed
the
feature_profiles
branch
from
52d2210
to
887fd3f
Compare
wutschel
force-pushed
the
feature_profiles
branch
from
887fd3f
to
3d43723
Compare
Only load non-active profile and request password prompt.
This ensures the App's cached library content matches the content reachable for the active user profile.
wutschel
force-pushed
the
feature_profiles
branch
from
3d43723
to
66f4d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #38.
This PR implements support for user profiles. Profiles can be reached via the Settings menu. The available profiles (incl. thumbnails) are listed, and the current active profile is highlighted. When selecting another profile it is attempted to load it.
Screenshots:
Summary for release notes
Feature: Support listing/loading profiles