Bugfix: restore GlobalSearch sort method and sort order #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not needed and impacts restoring sort method and sort order of GlobalSearch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes and issue reported in this forum post.
The issue was caused by #1145, which resulted in GlobalSearch having
methodequal tonilinstead of@[@{}]. This in consequence resulted in sort method and sort order not being restored anymore. This PR fixes this by removing the check for nil when restoring, as it is not required for robustness or function.Summary for release notes
Bugfix: restore GlobalSearch sort method and sort order