Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework image cache #1186

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Rework image cache #1186

wants to merge 7 commits into from

Commits on Nov 3, 2024

  1. Use image view's bounds size for scaling

    @wutschel
    wutschel committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    9e383bf View commit details
    Browse the repository at this point in the history

  2. Rework image scaling 

    - Only create color space, if needed, to avoid excessive memory consumption when keeping the image size.
- Remove the image parameter as all of this is given by self.
- Remove the quality parameter as callers used same value.
- Let image scaling support different content scale modes
    @wutschel
    wutschel committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    e23f651 View commit details
    Browse the repository at this point in the history

  3. Use reworked image scaler to avoid code duplication

    @wutschel
    wutschel committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    3991c59 View commit details
    Browse the repository at this point in the history

  4. Let the image scaling follow the target view's content mode

    @wutschel
    wutschel committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    d2afed0 View commit details
    Browse the repository at this point in the history

  5. Reduce memory usage of image cache 

    Not setting bytes-per-row somehow does not cause to retain CG context. This reduces the memory usage of the image cache to 50% when having shouldDecompressImages enabled.
    @wutschel
    wutschel committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    e3bbaa1 View commit details
    Browse the repository at this point in the history

  6. Deactivate image decompression in cache memory 

    This reduces the processing load when loading images from flash to RAM. But it also ends up in retaining the flash data from which the UIImages are created. This increases the image memory cache size by about 25%.
    @wutschel
    wutschel committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    c4ce633 View commit details
    Browse the repository at this point in the history

  7. Rework colorizeImage 

    Removes not needed calculations of dimensions.
    @wutschel
    wutschel committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    e595f00 View commit details
    Browse the repository at this point in the history