Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the tests from the examples and update of the related .md files #303

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Split the tests from the examples and update of the related .md files #303

wants to merge 5 commits into from

Conversation

rfj82982
Copy link
Collaborator

Second part of the update the Test PR. Now all tests are moved under the forlder tests. Only the Wind Turbine needs fixing but this will be done in a dedicated PR.

pbartholomew08
pbartholomew08 requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@pbartholomew08 pbartholomew08 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, but looks good!

In the examples where I could see values in the input where changing I tried to highlight model/physics values in case these have changed over time unintentionally.

.github/workflows/generate_reference_test_data.yml Show resolved Hide resolved
examples/ABL-Atmospheric-Boundary-Layer/input.i3d Show resolved Hide resolved
examples/ABL-Atmospheric-Boundary-Layer/input.i3d Show resolved Hide resolved
examples/ABL-Atmospheric-Boundary-Layer/input.i3d Show resolved Hide resolved
examples/ABL-Atmospheric-Boundary-Layer/input.i3d Show resolved Hide resolved
examples/CMakeLists.txt Show resolved Hide resolved
examples/Cavity/CMakeLists.txt Outdated Show resolved Hide resolved
examples/cmake/X3D_ADD_EXAMPLE.cmake Show resolved Hide resolved
tests/cmake/X3D_CREATE_TEST.cmake Show resolved Hide resolved
tests/TGV-Taylor-Green-vortex/README.md Outdated Show resolved Hide resolved
mathrack
mathrack requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@mathrack mathrack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR should be limited to the (CMake) testing framework. If possible, please avoid updating / deleting input files here.

@rfj82982
Copy link
Collaborator Author

Still to fix (next PR or 2):

  • Put back in the install and test the Wind-Turbine
  • Include in the install and test the particles
  • Fix the TGV case for single precision (I guess this requires a dedicated PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathrack mathrack Awaiting requested review from mathrack

@pbartholomew08 pbartholomew08 Awaiting requested review from pbartholomew08

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfj82982 @pbartholomew08 @mathrack