Skip to content

Conversation

@JamieJQuinn
Copy link
Collaborator

This PR fixes a number of issues:

  • fprettify will now ignore the entire file src/cuda/exec_dist.f90 to avoid it messing with the CUDA chevrons
  • Github Actions no longer reports fprettify failing as a true failure; instead it posts a warning, however there's now no obvious indication that a run has failed.
  • Updated various github actions to latest versions and pinned their Python version.
  • Removed check for Conventional Commits.

Note: the fprettify chevron bugfix has been submitted so the above hack to just remove the file entirely will be no longer needed once the corresponding PR has been merged and fprettify updated.

@JamieJQuinn JamieJQuinn requested review from Nanoseb and semi-h February 8, 2024 17:51
@Nanoseb
Copy link
Collaborator

Nanoseb commented Feb 8, 2024

Looks good to me. Though I'd also remove mentions of the "conventional commit" thing in the documentation. I think it is mainly here: https://github.com/xcompact3d/x3d2/blob/main/docs/source/developer/contributing_guidelines.rst

@slaizet slaizet merged commit f5184a7 into main Feb 9, 2024
@JamieJQuinn JamieJQuinn mentioned this pull request Feb 9, 2024
ia267 pushed a commit to ia267/x3d2 that referenced this pull request Feb 5, 2025
Cleanup Github Actions and fix fprettify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants