Upgrade: forbid upgrading with a key XAPI will reject #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
force-pushed
the
certificate-keysize-protection
branch
from
5657964
to
3e34037
Compare
bleader
approved these changes
Sep 16, 2024
benjamreis
approved these changes
Sep 16, 2024
|
See remark at xenserver#167 (review) |
XAPI now rejects the default keysize of 7.x era, which must be regenerated before upgrading to 8.3. Let the installer refuse to initiate a situation where a Rolling Pool Upgrade would be unable to proceed, with not-yet-updated slaves holding the running VMs getting refused connection to the updated part of the pool. Signed-off-by: Yann Dirson <[email protected]>
ydirson
force-pushed
the
certificate-keysize-protection
branch
from
3e34037
to
6265ada
Compare
|
applied remarks from upstream PR |
bleader
approved these changes
Sep 16, 2024
benjamreis
approved these changes
Sep 17, 2024
stormi
reviewed
Sep 17, 2024
| primary_fs.unmount() | ||
|
|
||
| def testUpgradeForbidden(self, tool): | ||
| utilparts = tool.utilityPartitions() | ||
| if tool.partTableType == constants.PARTITION_DOS and utilparts is not None: | ||
| raise RuntimeError("Util partition detected on DOS partition type, upgrade forbidden.") | ||
| if self.key_size < constants.MIN_KEY_SIZE: | ||
| raise RuntimeError("Current server certificate is too small (%s bits), please regenerate with at least %s bits." % (self.key_size, constants.MIN_KEY_SIZE)) |
There was a problem hiding this comment.
Can we add "(see the Release Notes for XCP-ng 8.3)" ? This will likely remain accurate even if people upgrade to a later release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XAPI now rejects the default keysize of 7.x era, which must be regenerated before upgrading to 8.3. Let the installer refuse to initiate a situation where a Rolling Pool Upgrade would be unable to proceed, with not-yet-updated slaves holding the running VMs getting refused connection to the updated part of the pool.
Results in this failure, but only after the user gave authorization to write the backup:
Submitted upstream as xenserver#167