Skip to content

Conversation

gthvn1
Copy link

@gthvn1 gthvn1 commented Aug 11, 2025

No description provided.

@gthvn1 gthvn1 requested a review from gduperrey August 11, 2025 15:32
@gthvn1 gthvn1 force-pushed the gtn-add-custom-files-doc branch from 7379b31 to b274551 Compare August 11, 2025 18:03
@glehmann
Copy link
Member

The user repositories are already installed by init-container.sh (

if [ -n "$XCPREL" ]; then
curl -s https://koji.xcp-ng.org/repos/user/${XCPREL}/xcpng-users.repo |
sed '/^gpgkey=/ ipriority=1' | sudo tee /etc/yum.repos.d/xcp-ng-users.repo > /dev/null
fi
) so this may not be the best example 🙂

@stormi stormi requested a review from glehmann August 25, 2025 16:24
@stormi
Copy link
Member

stormi commented Aug 25, 2025

Added Gaëtan as reviewer because he has a strong point.

Copy link

@ydirson ydirson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're moving towards publishing the build-env in an image registry, this approach for adding files does not look like a long-term one.
Some use-cases can likely be addressed when launching the container, by bind-mounting the file into the image, which for the example given would be something like -v /tmp/xcpng-users.repo:/etc/yum.repos.d/xcpng-users.repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants