-
Notifications
You must be signed in to change notification settings - Fork 22
Remove xcp-ng-dev-env-create #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
069bfd0
to
d02c99c
Compare
For a PR that undoes what someone else did, I 'd prefer a discussion first, before a merge request (which, unless stated otherwise, any PR which is not a draft is). |
I've converted it to a draft. The discussion started in #36 (comment), and I've created a new PR to ensure the subject isn't hidden in the ghcr.io discussion. |
644d3ed
to
223c7b1
Compare
7256437
to
b548c4d
Compare
223c7b1
to
3d7b5ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many renames but the reason is not given. Maybe it is not necessary to revert the whole original commit?
3d7b5ae
to
b26e293
Compare
b548c4d
to
ab215b9
Compare
b26e293
to
30f8a45
Compare
ab215b9
to
3855266
Compare
Ok, I thought it was clear by itself, but I was obviously wrong. I removed the command to avoid collision with the main tool and because the image could be downloaded from ghcr.io. This is just acknowledging the new situation with the downloadable image, which wasn't there in the previous PR. I feel like it's just the normal evolution of the code 🙂 |
Can these files be moved to a new subdirectory |
f43dc8a
to
4e55d8b
Compare
done |
30f8a45
to
daf6f12
Compare
8af7939
to
5d46673
Compare
daf6f12
to
f07d40a
Compare
5d46673
to
6dac1c8
Compare
f07d40a
to
c4112b4
Compare
6dac1c8
to
bc97ed6
Compare
c4112b4
to
1c18d26
Compare
Now that the images are easily available on ghcr.io. It makes the completion easier to use for the main tool. Signed-off-by: Gaëtan Lehmann <[email protected]>
bc97ed6
to
ea64c2b
Compare
Now that the images are easily available on ghcr.io.
It makes the completion easier to use for the main tool.
PR stacked on #37