Skip to content

Conversation

glehmann
Copy link
Member

@glehmann glehmann commented Sep 5, 2025

Now that the images are easily available on ghcr.io.
It makes the completion easier to use for the main tool.

PR stacked on #37

@glehmann glehmann force-pushed the gln/remove-xcpng-dev-env-uxkl branch 2 times, most recently from 069bfd0 to d02c99c Compare September 5, 2025 20:50
@stormi
Copy link
Member

stormi commented Sep 5, 2025

For a PR that undoes what someone else did, I 'd prefer a discussion first, before a merge request (which, unless stated otherwise, any PR which is not a draft is).

@glehmann glehmann marked this pull request as draft September 5, 2025 21:04
@glehmann
Copy link
Member Author

glehmann commented Sep 5, 2025

I've converted it to a draft.

The discussion started in #36 (comment), and I've created a new PR to ensure the subject isn't hidden in the ghcr.io discussion.

@glehmann glehmann force-pushed the gln/build-env-improvements-lzqx branch from 644d3ed to 223c7b1 Compare September 5, 2025 22:00
@glehmann glehmann force-pushed the gln/remove-xcpng-dev-env-uxkl branch 2 times, most recently from 7256437 to b548c4d Compare September 6, 2025 12:14
@glehmann glehmann force-pushed the gln/build-env-improvements-lzqx branch from 223c7b1 to 3d7b5ae Compare September 6, 2025 12:14
Copy link

@ydirson ydirson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many renames but the reason is not given. Maybe it is not necessary to revert the whole original commit?

@glehmann glehmann force-pushed the gln/build-env-improvements-lzqx branch from 3d7b5ae to b26e293 Compare September 8, 2025 12:51
@glehmann glehmann force-pushed the gln/remove-xcpng-dev-env-uxkl branch from b548c4d to ab215b9 Compare September 8, 2025 12:51
@glehmann glehmann force-pushed the gln/build-env-improvements-lzqx branch from b26e293 to 30f8a45 Compare September 8, 2025 16:41
@glehmann glehmann force-pushed the gln/remove-xcpng-dev-env-uxkl branch from ab215b9 to 3855266 Compare September 8, 2025 16:41
@glehmann
Copy link
Member Author

glehmann commented Sep 8, 2025

There are many renames but the reason is not given. Maybe it is not necessary to revert the whole original commit?

Ok, I thought it was clear by itself, but I was obviously wrong.

I removed the command to avoid collision with the main tool and because the image could be downloaded from ghcr.io.
I've moved build.sh to the root of the repository to make it more accessible than in the subdirectories, where it has no point to be, since there is no (easy) way to call it anymore. And I moved the files linked to the build as well.

This is just acknowledging the new situation with the downloadable image, which wasn't there in the previous PR. I feel like it's just the normal evolution of the code 🙂

@psafont
Copy link

psafont commented Sep 9, 2025

Can these files be moved to a new subdirectory container? It makes it easier to associate all these files with the container subcommand

@glehmann glehmann force-pushed the gln/remove-xcpng-dev-env-uxkl branch 2 times, most recently from f43dc8a to 4e55d8b Compare September 9, 2025 20:31
@glehmann
Copy link
Member Author

glehmann commented Sep 9, 2025

done

@glehmann glehmann force-pushed the gln/build-env-improvements-lzqx branch from 30f8a45 to daf6f12 Compare September 10, 2025 12:18
@glehmann glehmann force-pushed the gln/remove-xcpng-dev-env-uxkl branch 2 times, most recently from 8af7939 to 5d46673 Compare September 10, 2025 12:28
@glehmann glehmann force-pushed the gln/build-env-improvements-lzqx branch from daf6f12 to f07d40a Compare September 10, 2025 12:28
@glehmann glehmann force-pushed the gln/remove-xcpng-dev-env-uxkl branch from 5d46673 to 6dac1c8 Compare September 10, 2025 12:45
@glehmann glehmann force-pushed the gln/build-env-improvements-lzqx branch from f07d40a to c4112b4 Compare September 10, 2025 12:45
@glehmann glehmann marked this pull request as ready for review September 10, 2025 13:20
@glehmann glehmann force-pushed the gln/remove-xcpng-dev-env-uxkl branch from 6dac1c8 to bc97ed6 Compare September 10, 2025 15:33
@glehmann glehmann force-pushed the gln/build-env-improvements-lzqx branch from c4112b4 to 1c18d26 Compare September 10, 2025 15:33
Base automatically changed from gln/build-env-improvements-lzqx to master September 11, 2025 08:02
Now that the images are easily available on ghcr.io.
It makes the completion easier to use for the main tool.

Signed-off-by: Gaëtan Lehmann <[email protected]>
@glehmann glehmann force-pushed the gln/remove-xcpng-dev-env-uxkl branch from bc97ed6 to ea64c2b Compare September 11, 2025 08:29
@glehmann glehmann requested a review from ydirson September 15, 2025 13:12
@glehmann glehmann merged commit 102f2fa into master Sep 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants