lib/vdi: Add VDI resize support and integrate into VM & linstor operations #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When marking a PR ready for review, please also add a comment, as Github apparently doesn't always notify of this kind of change. |
Wescoeur
requested changes
Feb 17, 2025
rushikeshjadhav
force-pushed
the
feat-storage-linstor-684
branch
from
f7ff4b3 to
88b5273
Compare
rushikeshjadhav
changed the title
stormi
reviewed
Feb 19, 2025
stormi
reviewed
Feb 19, 2025
stormi
reviewed
Feb 19, 2025
Comment on lines
83
to
89
| def test_resize_vdi(self, vm_on_linstor_sr): | ||
| vm = vm_on_linstor_sr | ||
| if vm.is_running(): | ||
| vm.shutdown(verify=True, force_if_fails=True) | ||
| logging.info("* VDI Resize started *") | ||
| for vdi_uuid in vm.vdi_uuids(): | ||
| vm.vdi_resize(vdi_uuid) | ||
| logging.info("* VDI Resize completed *") | ||
|
|
There was a problem hiding this comment.
This looks like a test we might want to add to tests of all other SRs (in a separate PR once this one is merged?)
There was a problem hiding this comment.
Yes, this one is generally applicable to all storage tests that we have.
rushikeshjadhav
force-pushed
the
feat-storage-linstor-684
branch
2 times, most recently
from
f70b1ae to
57ee6c2
Compare
stormi
approved these changes
Feb 24, 2025
rushikeshjadhav
force-pushed
the
feat-storage-linstor-684
branch
3 times, most recently
from
1766c1c to
ddcc865
Compare
…uring availability across all hosts and handling "auto" selection dynamically. Signed-off-by: Rushikesh Jadhav <[email protected]>
…collectively, refining vgcreate and pvcreate logic. Signed-off-by: Rushikesh Jadhav <[email protected]>
…, reducing setup time. Signed-off-by: Rushikesh Jadhav <[email protected]>
…namically configure storage provisioning (thin or thick). Refactored Linstor SR test cases to use the new fixtures, improving test coverage across provisioning types. Signed-off-by: Rushikesh Jadhav <[email protected]>
…ia `xe vdi-resize` in `vdi.py` Signed-off-by: Rushikesh Jadhav <[email protected]>
…zing. - VM operations to include `wait_for_vm_running` method. Signed-off-by: Rushikesh Jadhav <[email protected]>
- Implemented `test_resize_vdi` in Linstor, verifying VDI resize functionality and ensuring VM boot post-resize. Signed-off-by: Rushikesh Jadhav <[email protected]>
rushikeshjadhav
force-pushed
the
feat-storage-linstor-684
branch
from
ddcc865 to
fdc4d32
Compare
ydirson
requested changes
Mar 13, 2025
| # MIN_VHD_SIZE = 1 * 1024 * 1024 # 1MB | ||
|
|
||
| # Following assert may be removed in future if we support online vdi resize | ||
| assert not self.is_running(), f"Expected halted, got running" |
There was a problem hiding this comment.
There are more states than just "running" and halted, that would probably need assert self.is_halted() here
| # Following assert may be removed in future if we support online vdi resize | ||
| assert not self.is_running(), f"Expected halted, got running" | ||
|
|
||
| vdi_obj = VDI(vdi_uuid, sr=self.get_sr()) |
There was a problem hiding this comment.
just vdi would be suitable, no need for _obj
| if new_size is None: | ||
| # Resize by double, ideally it should be within min and max limits reference | ||
| vdi_size = int(vdi_obj.param_get("virtual-size")) | ||
| new_size = str(vdi_size * 2) |
There was a problem hiding this comment.
It would be cleaner to use integers to manipulate size objects. Host.xe() already handles the conversion to string anyway.
To make such things more visible, it would be great to add type hints to new methods, eg:
def vdi_resize(self, vdi_uuid: str, new_size: Optional[int] = None) -> None:
...| new_size = str(vdi_size * 2) | ||
|
|
||
| vdi_obj.resize(new_size) | ||
| resized_vdi_size = vdi_obj.param_get("virtual-size") |
There was a problem hiding this comment.
same idea, better convert to int directly here
| @pytest.mark.big_vm | ||
| def test_resize_vdi(self, vm_on_linstor_sr): | ||
| vm = vm_on_linstor_sr | ||
| logging.info("* VDI Resize started *") |
There was a problem hiding this comment.
Do we really want * marker in the logs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resizemethod toVDIclass to allow resizing of VDIs viaxe vdi-resize.vdi_resizemethod in VM class to support 2x VDI resizing.test_resize_vdiin Linstor and basic VM tests, verifying VDI resize functionality and ensuring VM boot post-resize.wait_for_vm_running.