Implement storage nfs-on-slave test #341
Open
+57
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tperard
force-pushed
the
apd-nfs-on-slave
branch
from
6afd538 to
d450bb2
Compare
stormi
reviewed
Jul 18, 2025
tperard
force-pushed
the
apd-nfs-on-slave
branch
from
d450bb2 to
81dd04c
Compare
Nambrok
requested changes
Jul 25, 2025
tperard
force-pushed
the
apd-nfs-on-slave
branch
from
81dd04c to
b34c3f5
Compare
Millefeuille42
approved these changes
Aug 1, 2025
tperard
force-pushed
the
apd-nfs-on-slave
branch
from
b34c3f5 to
e498c5b
Compare
|
Just a rebase. |
stormi
reviewed
Sep 22, 2025
stormi
reviewed
Sep 22, 2025
tperard
force-pushed
the
apd-nfs-on-slave
branch
from
e498c5b to
ef3eaa9
Compare
ydirson
requested changes
Oct 2, 2025
Comment on lines
+44
to
+47
| vm.start() | ||
| vm.wait_for_os_booted() |
There was a problem hiding this comment.
Shouldn't the start/shutdown be handled by a fixture? Looks like a test failure here would not shutdown that VM we started.
There was a problem hiding this comment.
Looks like this would break test_reboot which reboot the host before starting the guest.
Or do you mean adding a fixture that uses vm_on_nfs_sr?
But vm_on_nfs_sr does a vm.destroy(). Is that enough?
tests/storage/nfs/test_nfs_sr.py
Outdated
|
|
||
| @pytest.mark.small_vm | ||
| @pytest.mark.usefixtures('hostA2') | ||
| def test_plugin_nfs_on_on_slave(self, vm_on_nfs_sr: 'VM'): |
There was a problem hiding this comment.
A note on what we expect from this plugin would be nice.
glehmann
reviewed
Oct 2, 2025
| vm.wait_for_os_booted() | ||
| host = vm.get_residence_host() | ||
|
|
||
| vdi = VDI(vm.vdi_uuids()[0], host=host) |
There was a problem hiding this comment.
Can't it be just vdi = vm.vdis[0]?
There was a problem hiding this comment.
I don't know, vm.vdis looks like brand new code.
Signed-off-by: Anthony PERARD <[email protected]>
.. for functions that are going to be used by test_plugin_nfs_on_on_slave(). Signed-off-by: Anthony PERARD <[email protected]>
This new test ensures that the "nfs-on-slave" host-plugin does check something, and return different result based on the environment. Signed-off-by: Anthony PERARD <[email protected]>
tperard
force-pushed
the
apd-nfs-on-slave
branch
from
ef3eaa9 to
5d89924
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new test ensures that the "nfs-on-slave" host-plugin does
check something, and return different result based on the environment.
the extension for the path. It's currently hard-coded to .vhd.