Open
Conversation
stormi
approved these changes
Apr 15, 2026
Wescoeur
requested changes
Apr 15, 2026
In the case of `vdi_is_open` tests, we are using a script to obtain the sr_ref of XAPI. This script doesn't free the XAPI session it obtained. ``` Apr 15 09:46:55 r620-x1 xapi: [debug||115 db_gc|DB GC D:d2304dcf287c|db_gc_util] Session.destroy _ref=OpaqueRef:77699499-92e7-ad96-2703-fc53adaae642 uuid=e8a67d26-9aae-4451-ea87-66a3180141fb trackid=3c4e5b67d27d1b17ff45f3e41b478632 (last active 20260414T07:46:32Z): Timed out session in group 'originator:xcp-ng-tests session' because of its age ``` This add the logout to the script to avoid leaking the session. Signed-off-by: Damien Thenot <damien.thenot@vates.tech> Co-authored-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Nambrok
force-pushed
the
dtt-fix-session-leak-is-open
branch
from
ee83e03 to
154e71e
Compare
Wescoeur
approved these changes
Apr 15, 2026
Member
|
nitpicking: "session leak" seems scarier than necessary. I'd rather call it "dangling session" |
Contributor
Author
Leak completely describe the situation though ^^ |
Member
|
It's not leaked in the sense that someone can't get the token or whatever represents the session and do something not allowed. The session is still open for the server, but nobody can use it. |
Member
|
Can we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of
vdi_is_opentests, we are using a script to obtain the sr_ref of XAPI. This script doesn't free the XAPI session it obtained.This add the logout to the script to avoid leaking the session.