koji_build.py: wait for the internal repo to be up to date #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `--wait-repo` to `koji build` so that it starts the task with a waitrepo subtask which ensures that the internal repository for the build tag is up to date. Signed-off-by: Samuel Verschelde <[email protected]>
|
Is there a reason why it's not the default in koji? |
I'll tell you if they answer my questions. I found it documented in https://docs.pagure.org/koji/repo_generation/ which covers the new behaviour of kojira regarding repo generation, but it doesn't tell why it isn't the default. Also, I've seen waitrepo tasks in some cases before some builds, shortly after the upgrade, so I'm not sure. But adding it seems to be an improvement to make sure we avoid bad surprises when doing a build shortly after another one. |
glehmann
approved these changes
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--wait-repotokoji buildso that it starts the task with a waitrepo subtask which ensures that the internal repository for the build tag is up to date.