koji: Lint koji_build.py file a bit and relax linter #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first pass fixing important and low hanging fruits. Pylint now passing (with relaxed header). It will be appreciated if future changes can pass linter, and feel free to make it strictier. Signed-off-by: Philippe Coval <[email protected]>
Member
|
Have you talked with Yann and Gaëtan about it? There may be a need for coordination with the broader linting efforts. |
stormi
reviewed
Nov 28, 2025
| # prev_branch is empty when the head was detached | ||
| subprocess.check_call(['git', 'checkout', prev_branch or commit]) | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Doubling newlines is not a rule we chose to enforce at the moment.
Contributor
Author
There was a problem hiding this comment.
ok i can revert this, fyi flake8 complained about that
stormi
reviewed
Nov 28, 2025
| return f'{spec.release}.0.{test_build_id}.{build_nb}' | ||
| else: | ||
| return f'{spec.release}~{pre_build_id}.{build_nb}' | ||
| return f'{spec.release}~{pre_build_id}.{build_nb}' |
Member
There was a problem hiding this comment.
We avoided an else, but do we need to enforce that?
Contributor
Author
There was a problem hiding this comment.
Sure we can skip it
scripts/koji/koji_build.py:145:4: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
stormi
reviewed
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass fixing important and low hanging fruits. Pylint now passing (with relaxed header).
It will be appreciated if future changes can pass linter, and feel free to make it strictier.