Add global, address_of, array_ref, load, store, ref<T> #19
+411
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
reviewed
Jun 10, 2025
superlopuh
reviewed
Jun 10, 2025
superlopuh
reviewed
Jun 10, 2025
alastairreid
requested review from
math-fehr and
superlopuh
and removed request for
superlopuh
Contributor
Author
|
oops - I was looking at a stale browser window - ignore review request - I will read the comments you have already made |
alastairreid
force-pushed
the
areid/globals
branch
from
be0a73f to
50f5fe5
Compare
alastairreid
force-pushed
the
areid/globals
branch
from
fe034f1 to
7c07542
Compare
This does not work yet - an error at runtime when doing the symbol lookup. But hopefully it is heading in the right direction.
Member
|
Would it be helpful for me to try and debug this locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.