This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Add zipkin(alfresco-zipkin-[repo|share]), share-war dependencies #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split zipkin, alfresco-zipkin-repo, alfresco-zipkin-share add share war dependency so share amp can be applied
tgeens
reviewed
Aug 13, 2019
| @Override | ||
| public void customize(DockerCompose compose) { | ||
| DockerComposeModel zipkinModel = compose.file("zipkin"); | ||
| ComposeServices services = zipkinModel.getServices(); |
There was a problem hiding this comment.
Alfresco doesn't need any configuration ?
There was a problem hiding this comment.
It does, see the customizer for alfresco-zipkin-repo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
share-war needed to be added as well, since you don't seem to be able to apply amps to a share war in an image without declaring
shareWarin thebuild.gradle