Implement axis directionality (in low-level ufuncs)#665
Draft
hdrake wants to merge 1 commit intoxgcm:masterfrom
Draft
Implement axis directionality (in low-level ufuncs)#665hdrake wants to merge 1 commit intoxgcm:masterfrom
hdrake wants to merge 1 commit intoxgcm:masterfrom
Conversation
Collaborator
Author
|
@TomNicholas, I started reading through your big ufunc PR and the source code. I would love to take you up on your offer of walking me through the current state of the code, and then maybe you can talk me through how you would approach this PR as a concrete example. Pinging @NoraLoose, @raphaeldussin, and my new postdoc @liu-ran to keep them in the loop. Easiest to coordinate a call over email? |
Collaborator
Author
Member
|
Sounds good. I'm going to have to remind myself of how all this works 😅 My email is Tom at Earthmover dot io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to revive prior efforts to add a sense of directionality to xgcm grid axes, especially #338.
Unfortunately, @gmacgilchrist's prior attempt at this PR predated the ufunc-ification of grid operations (see PR #479 and the issue it closes #344), which meant that it eventually became stale and was closed.
pre-commit run --all-fileswhats-new.rstapi.rst