-
Notifications
You must be signed in to change notification settings - Fork 10
Windows Excel like behavior for grid column filtering #3894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f4063c8
ready for review
oodarluz 82e2ff9
fixes pre PR
oodarluz f1d2990
trimming code
oodarluz 4c916e9
done
oodarluz 18d9f6e
done
oodarluz 1432952
post CR with colin state change
oodarluz 16d74c3
comment layout correction
oodarluz 06796cc
post review changes set commit on change to false add change log
oodarluz be269c3
Merge confilct in change log
oodarluz f3b08e6
merge conflict and catchup
oodarluz 8a3d862
Merge branch 'develop' into grid-column-filter
amcclain ad0bad9
Merge branch 'refs/heads/develop' into grid-column-filter
cnrudd 3ef05a7
Merge branch 'refs/heads/develop' into grid-column-filter
cnrudd 03371a9
Merge branch 'refs/heads/develop' into grid-column-filter
cnrudd 8d173f4
Add missing model prop to storeFilterField
cnrudd 42286e2
revert prior commit
cnrudd f8f1e3c
clarify commment
cnrudd ea25832
Bugfix: ensure only the value field is filtered. Don't want 'al' to …
cnrudd 3dde7f6
More rigorously follow Excel on Windows behaviour when filterModel.co…
cnrudd fadc84e
Hide combineCurrentFilters checkbox if there are no current filters
cnrudd 63bf4c0
Merge branch 'refs/heads/develop' into grid-column-filter
cnrudd 7c24203
update changelog entry to add grid column header UX changes.
cnrudd 13cbdb2
Merge branch 'refs/heads/develop' into grid-column-filter
cnrudd 9d6b014
Grid column filter values tab: Make select and add checkbox labels cl…
cnrudd d2bef43
Grid column filter values tab: Space Bar toggles checkbox in grid row.
cnrudd 5a44a4d
Merge branch 'refs/heads/develop' into grid-column-filter
cnrudd b72436e
CR with Lee.
cnrudd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
13 changes: 13 additions & 0 deletions
13
desktop/cmp/grid/impl/filter/headerfilter/values/ValuesTab.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.