Multi instance #670
Merged
Multi instance #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.gradle # client-app/yarn.lock
# Conflicts: # client-app/yarn.lock
+ Remove extraneous controller
+ Working to get this setup on our Fargate-based ECS instance w/o multicast
…ects of cluster configuration
# Conflicts: # CHANGELOG.md
# Conflicts: # client-app/yarn.lock
# Conflicts: # client-app/yarn.lock
# Conflicts: # client-app/package.json # client-app/src/admin/AppModel.ts # client-app/src/apps/admin.ts # client-app/src/desktop/AppModel.ts # client-app/yarn.lock # grails-app/controllers/io/xh/toolbox/portfolio/PortfolioController.groovy # grails-app/services/io/xh/toolbox/security/Auth0Service.groovy
ghsolomon
reviewed
Aug 24, 2024
| ) | ||
| } | ||
| return _newsItems ? _newsItems : Collections.emptyList() | ||
| newsTimer = newsTimer ?: createTimer( |
There was a problem hiding this comment.
Flagging to discuss (related to our Timer conversation yesterday). I could be missing something. It seems like if a non-primary node is hit first, _newsItems will be empty, the timer runFn will not run, and this method will fail to return any news items.
There was a problem hiding this comment.
correct -- this would benefit from waiting
There was a problem hiding this comment.
Yeah- except this timer is lazily created, so I believe it could end up waiting indefinitely (until the same method happens to be called on the primary node).
I have some ideas I'd love to discuss tomorrow if you've got time.
|
sure -- looking forward to it!
…On Sun, Aug 25, 2024 at 11:33 AM Greg Solomon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In grails-app/services/io/xh/toolbox/app/NewsService.groovy
<#670 (comment)>:
> @@ -20,15 +22,15 @@ class NewsService extends BaseService {
List<NewsItem> getNewsItems() {
// to avoid hitting the API too frequently, we only start our timer when the NewsService is actually used.
- if (!newsTimer) {
- newsTimer = createTimer(
- runFn: this.&loadAllNews,
- interval: 'newsRefreshMins',
- intervalUnits: MINUTES,
- runImmediatelyAndBlock: true
- )
- }
- return _newsItems ? _newsItems : Collections.emptyList()
+ newsTimer = newsTimer ?: createTimer(
Yeah- except this timer is lazily created, so I believe it could end up
waiting indefinitely (until the same method happens to be called on the
primary node).
I have some ideas I'd love to discuss tomorrow if you've got time.
—
Reply to this email directly, view it on GitHub
<#670 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARTL2MVJZYSOYWTIVRCH3DZTH2K3AVCNFSM6AAAAAA4FJN34KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJZGMZDMMRUG4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.